Viewing: osp_trans.c
// SPDX-License-Identifier: GPL-2.0
/*
* Copyright (c) 2014, 2017, Intel Corporation.
*/
/*
* 1. OSP (Object Storage Proxy) transaction methods
*
* Implement OSP layer transaction related interfaces for the dt_device API
* dt_device_operations.
*
*
* 2. Handle asynchronous idempotent operations
*
* The OSP uses OUT (Object Unified Target) RPC to talk with other server
* (MDT or OST) for kinds of operations, such as create, unlink, insert,
* delete, lookup, set_(x)attr, get_(x)attr, and etc. To reduce the number
* of RPCs, we allow multiple operations to be packaged together in single
* OUT RPC.
*
* For the asynchronous idempotent operations, such as get_(x)attr, related
* RPCs will be inserted into an osp_device based shared asynchronous request
* queue - osp_device::opd_async_requests. When the queue is full, all the
* requests in the queue will be packaged into a single OUT RPC and given to
* the ptlrpcd daemon (for sending), then the queue is purged and other new
* requests can be inserted into it.
*
* When the asynchronous idempotent operation inserts the request into the
* shared queue, it will register an interpreter. When the packaged OUT RPC
* is replied (or failed to be sent out), all the registered interpreters
* will be called one by one to handle each own result.
*
*
* There are three kinds of transactions
*
* 1. Local transaction, all of updates of the transaction are in the local MDT.
* 2. Remote transaction, all of updates of the transaction are in one remote
* MDT, which only happens in LFSCK now.
* 3. Distribute transaction, updates for the transaction are in mulitple MDTs.
*
* Author: Di Wang <di.wang@intel.com>
* Author: Fan, Yong <fan.yong@intel.com>
*/
#define DEBUG_SUBSYSTEM S_MDS
#include <lustre_net.h>
#include "osp_internal.h"
/*
* The argument for the interpreter callback of osp request.
*/
struct osp_update_args {
struct osp_update_request *oaua_update;
atomic_t *oaua_count;
wait_queue_head_t *oaua_waitq;
bool oaua_flow_control;
const struct lu_env *oaua_update_env;
};
/*
* Call back for each update request.
*/
struct osp_update_callback {
/* list in the osp_update_request::our_cb_items */
struct list_head ouc_list;
/* The target of the async update request. */
struct osp_object *ouc_obj;
/* The data used by or_interpreter. */
void *ouc_data;
/* The interpreter function called after the async request handled. */
osp_update_interpreter_t ouc_interpreter;
};
/**
* osp_object_update_request_create() - Allocate new update request
* @our: osp_udate_request where to create a new update request
* @size: request size
*
* Allocate new update request and insert it to the req_update_list.
*
* Return:
* * %0 if creation succeeds.
* * %negative errno if creation fails.
*/
int osp_object_update_request_create(struct osp_update_request *our,
size_t size)
{
struct osp_update_request_sub *ours;
struct object_update_request *ourq;
OBD_ALLOC_PTR(ours);
if (ours == NULL)
return -ENOMEM;
/* The object update request will be added to an SG list for
* bulk transfer. Some IB HW cannot handle partial pages in SG
* lists (since they create gaps in memory regions) so we
* round the size up to the next multiple of PAGE_SIZE. See
* LU-9983.
*/
LASSERT(size > 0);
size = round_up(size, PAGE_SIZE);
OBD_ALLOC_LARGE(ourq, size);
if (ourq == NULL) {
OBD_FREE_PTR(ours);
return -ENOMEM;
}
ourq->ourq_magic = UPDATE_REQUEST_MAGIC;
ourq->ourq_count = 0;
ours->ours_req = ourq;
ours->ours_req_size = size;
INIT_LIST_HEAD(&ours->ours_list);
list_add_tail(&ours->ours_list, &our->our_req_list);
our->our_req_nr++;
return 0;
}
/**
* osp_current_object_update_request() - Get current update request
* @our: osp update request where to get the current object update.
*
* Get current object update request from our_req_list in
* osp_update_request, because we always insert the new update
* request in the last position, so the last update request
* in the list will be the current update req.
*
* Return the current updated object
*/
struct osp_update_request_sub *
osp_current_object_update_request(struct osp_update_request *our)
{
if (list_empty(&our->our_req_list))
return NULL;
return list_entry(our->our_req_list.prev, struct osp_update_request_sub,
ours_list);
}
/**
* osp_update_request_create() - Allocate and initialize osp_update_request
* @dt: dt device
*
* osp_update_request is being used to track updates being executed on
* this dt_device(OSD or OSP). The update buffer will be 4k initially,
* and increased if needed.
*
* Return:
* \retval osp_update_request being allocated if succeed
* \retval ERR_PTR(errno) if failed
*/
struct osp_update_request *osp_update_request_create(struct dt_device *dt)
{
struct osp_update_request *our;
int rc;
OBD_ALLOC_PTR(our);
if (our == NULL)
return ERR_PTR(-ENOMEM);
INIT_LIST_HEAD(&our->our_req_list);
INIT_LIST_HEAD(&our->our_cb_items);
INIT_LIST_HEAD(&our->our_list);
INIT_LIST_HEAD(&our->our_invalidate_cb_list);
spin_lock_init(&our->our_list_lock);
rc = osp_object_update_request_create(our, PAGE_SIZE);
if (rc != 0) {
OBD_FREE_PTR(our);
return ERR_PTR(rc);
}
return our;
}
void osp_update_request_destroy(const struct lu_env *env,
struct osp_update_request *our)
{
struct osp_update_request_sub *ours;
struct osp_update_request_sub *tmp;
if (our == NULL)
return;
list_for_each_entry_safe(ours, tmp, &our->our_req_list, ours_list) {
list_del(&ours->ours_list);
if (ours->ours_req != NULL)
OBD_FREE_LARGE(ours->ours_req, ours->ours_req_size);
OBD_FREE_PTR(ours);
}
if (!list_empty(&our->our_invalidate_cb_list)) {
struct lu_env lenv;
struct osp_object *obj;
struct osp_object *next;
if (env == NULL) {
lu_env_init(&lenv, LCT_MD_THREAD | LCT_DT_THREAD);
env = &lenv;
}
list_for_each_entry_safe(obj, next,
&our->our_invalidate_cb_list,
opo_invalidate_cb_list) {
spin_lock(&obj->opo_lock);
list_del_init(&obj->opo_invalidate_cb_list);
spin_unlock(&obj->opo_lock);
dt_object_put(env, &obj->opo_obj);
}
if (env == &lenv)
lu_env_fini(&lenv);
}
OBD_FREE_PTR(our);
}
static void
object_update_request_dump(const struct object_update_request *ourq,
unsigned int mask)
{
unsigned int i;
size_t total_size = 0;
for (i = 0; i < ourq->ourq_count; i++) {
struct object_update *update;
size_t size = 0;
update = object_update_request_get(ourq, i, &size);
LASSERT(update != NULL);
CDEBUG(mask, "i = %u fid = "DFID" op = %s params = %d batchid = %llu size = %zu repsize %u\n",
i, PFID(&update->ou_fid),
update_op_str(update->ou_type),
update->ou_params_count,
update->ou_batchid, size,
(unsigned int)update->ou_result_size);
total_size += size;
}
CDEBUG(mask, "updates = %p magic = %x count = %d size = %zu\n", ourq,
ourq->ourq_magic, ourq->ourq_count, total_size);
}
/**
* osp_prep_inline_update_req() - Prepare inline update request
* @env: execution environment
* @req: ptlrpc request
* @our: sub osp_update_request to be packed
* @repsize: arshad
*
* Prepare OUT update ptlrpc inline request, and the request usually includes
* one update buffer, which does not need bulk transfer.
*
* Return:
* * %0 if packing succeeds
* * %negative errno if packing fails
*/
static int osp_prep_inline_update_req(const struct lu_env *env,
struct ptlrpc_request *req,
struct osp_update_request *our,
int repsize)
{
struct osp_update_request_sub *ours;
struct out_update_header *ouh;
__u32 update_req_size;
int rc;
ours = list_first_entry(&our->our_req_list,
struct osp_update_request_sub, ours_list);
update_req_size = object_update_request_size(ours->ours_req);
req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_HEADER, RCL_CLIENT,
update_req_size + sizeof(*ouh));
rc = ptlrpc_request_pack(req, LUSTRE_MDS_VERSION, OUT_UPDATE);
if (rc != 0)
RETURN(rc);
ouh = req_capsule_client_get(&req->rq_pill, &RMF_OUT_UPDATE_HEADER);
ouh->ouh_magic = OUT_UPDATE_HEADER_MAGIC;
ouh->ouh_count = 1;
ouh->ouh_inline_length = update_req_size;
ouh->ouh_reply_size = repsize;
memcpy(ouh->ouh_inline_data, ours->ours_req, update_req_size);
req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_REPLY,
RCL_SERVER, repsize);
ptlrpc_request_set_replen(req);
req->rq_request_portal = OUT_PORTAL;
req->rq_reply_portal = OSC_REPLY_PORTAL;
RETURN(rc);
}
/**
* osp_prep_update_req() - Prepare update request.
* @env: execution environment
* @imp: import on which ptlrpc request will be sent
* @our: pointer to the osp_update_request
* @reqp: request to be created
*
* Prepare OUT update ptlrpc request, and the request usually includes
* all of updates (stored in @ureq) from one operation.
*
* Return:
* * %0 if preparation succeeds.
* * %negative errno if preparation fails.
*/
int osp_prep_update_req(const struct lu_env *env, struct obd_import *imp,
struct osp_update_request *our,
struct ptlrpc_request **reqp)
{
struct ptlrpc_request *req;
struct ptlrpc_bulk_desc *desc;
struct osp_update_request_sub *ours;
const struct object_update_request *ourq;
struct out_update_header *ouh;
struct out_update_buffer *oub;
__u32 buf_count = 0;
int page_count = 0;
int repsize = 0;
struct object_update_reply *reply;
int rc, i;
int total = 0;
ENTRY;
list_for_each_entry(ours, &our->our_req_list, ours_list) {
object_update_request_dump(ours->ours_req, D_INFO);
ourq = ours->ours_req;
for (i = 0; i < ourq->ourq_count; i++) {
struct object_update *update;
size_t size = 0;
/* XXX: it's very inefficient to lookup update
* this way, iterating from the beginning
* each time */
update = object_update_request_get(ourq, i, &size);
LASSERT(update != NULL);
repsize += sizeof(reply->ourp_lens[0]);
repsize += sizeof(struct object_update_result);
repsize += update->ou_result_size;
}
buf_count++;
}
repsize += sizeof(*reply);
if (repsize < OUT_UPDATE_REPLY_SIZE)
repsize = OUT_UPDATE_REPLY_SIZE;
LASSERT(buf_count > 0);
req = ptlrpc_request_alloc(imp, &RQF_OUT_UPDATE);
if (req == NULL)
RETURN(-ENOMEM);
if (buf_count == 1) {
ours = list_first_entry(&our->our_req_list,
struct osp_update_request_sub,
ours_list);
/* Let's check if it can be packed inline */
if (object_update_request_size(ours->ours_req) +
sizeof(struct out_update_header) <
OUT_UPDATE_MAX_INLINE_SIZE) {
rc = osp_prep_inline_update_req(env, req, our, repsize);
if (rc == 0)
*reqp = req;
GOTO(out_req, rc);
}
}
req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_HEADER, RCL_CLIENT,
sizeof(struct out_update_header));
req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_BUF, RCL_CLIENT,
buf_count * sizeof(*oub));
rc = ptlrpc_request_pack(req, LUSTRE_MDS_VERSION, OUT_UPDATE);
if (rc != 0)
GOTO(out_req, rc);
ouh = req_capsule_client_get(&req->rq_pill, &RMF_OUT_UPDATE_HEADER);
ouh->ouh_magic = OUT_UPDATE_HEADER_MAGIC;
ouh->ouh_count = buf_count;
ouh->ouh_inline_length = 0;
ouh->ouh_reply_size = repsize;
oub = req_capsule_client_get(&req->rq_pill, &RMF_OUT_UPDATE_BUF);
list_for_each_entry(ours, &our->our_req_list, ours_list) {
oub->oub_size = ours->ours_req_size;
oub++;
/* First *and* last might be partial pages, hence +1 */
page_count += DIV_ROUND_UP(ours->ours_req_size, PAGE_SIZE) + 1;
}
req->rq_bulk_write = 1;
desc = ptlrpc_prep_bulk_imp(req, page_count,
MD_MAX_BRW_SIZE >> LNET_MTU_BITS,
PTLRPC_BULK_GET_SOURCE,
MDS_BULK_PORTAL, &ptlrpc_bulk_kiov_nopin_ops);
if (desc == NULL)
GOTO(out_req, rc = -ENOMEM);
/* NB req now owns desc and will free it when it gets freed */
list_for_each_entry(ours, &our->our_req_list, ours_list) {
desc->bd_frag_ops->add_iov_frag(desc, ours->ours_req,
ours->ours_req_size);
total += ours->ours_req_size;
}
CDEBUG(D_OTHER, "total %d in %u\n", total, our->our_update_nr);
req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_REPLY,
RCL_SERVER, repsize);
ptlrpc_request_set_replen(req);
req->rq_request_portal = OUT_PORTAL;
req->rq_reply_portal = OSC_REPLY_PORTAL;
*reqp = req;
out_req:
if (rc < 0)
ptlrpc_req_put(req);
RETURN(rc);
}
/**
* osp_remote_sync() - Send update RPC.
* @env: execution environment
* @osp: pointer to the OSP device
* @our: hold all of updates which will be packed into the req
* @reqp: request to be created
*
* Send update request to the remote MDT synchronously.
*
* Return:
* * %0 if RPC succeeds.
* * %negative errno if RPC fails.
*/
int osp_remote_sync(const struct lu_env *env, struct osp_device *osp,
struct osp_update_request *our,
struct ptlrpc_request **reqp)
{
struct obd_import *imp = osp->opd_obd->u.cli.cl_import;
struct ptlrpc_request *req = NULL;
int rc;
ENTRY;
rc = osp_prep_update_req(env, imp, our, &req);
if (rc != 0)
RETURN(rc);
osp_set_req_replay(osp, req);
req->rq_allow_intr = 1;
/* Note: some dt index api might return non-zero result here, like
* osd_index_ea_lookup, so we should only check rc < 0 here */
rc = ptlrpc_queue_wait(req);
our->our_rc = rc;
if (rc < 0 || reqp == NULL)
ptlrpc_req_put(req);
else
*reqp = req;
RETURN(rc);
}
/**
* osp_thandle_invalidate_object() - Invalidate all objects in the osp thandle
* @env: execution environment
* @oth: osp thandle.
* @result:
*
* invalidate all of objects in the update request, which will be called
* when the transaction is aborted.
*/
static void osp_thandle_invalidate_object(const struct lu_env *env,
struct osp_thandle *oth,
int result)
{
struct osp_update_request *our = oth->ot_our;
struct osp_object *obj;
struct osp_object *next;
if (our == NULL)
return;
list_for_each_entry_safe(obj, next, &our->our_invalidate_cb_list,
opo_invalidate_cb_list) {
if (result < 0)
osp_invalidate(env, &obj->opo_obj);
spin_lock(&obj->opo_lock);
list_del_init(&obj->opo_invalidate_cb_list);
spin_unlock(&obj->opo_lock);
dt_object_put(env, &obj->opo_obj);
}
}
static void osp_trans_stop_cb(const struct lu_env *env,
struct osp_thandle *oth, int result)
{
struct dt_txn_commit_cb *dcb;
struct dt_txn_commit_cb *tmp;
/* call per-transaction stop callbacks if any */
list_for_each_entry_safe(dcb, tmp, &oth->ot_stop_dcb_list,
dcb_linkage) {
LASSERTF(dcb->dcb_magic == TRANS_COMMIT_CB_MAGIC,
"commit callback entry: magic=%x name='%s'\n",
dcb->dcb_magic, dcb->dcb_name);
list_del_init(&dcb->dcb_linkage);
dcb->dcb_func(NULL, &oth->ot_super, dcb, result);
}
osp_thandle_invalidate_object(env, oth, result);
}
/**
* osp_update_callback_init() - Allocate osp request and initialize it with the
* given parameters.
* @obj: pointer to the operation target
* @data: pointer to the data used by the interpreter
* @interpreter: pointer to the interpreter function
*
* Return:
* * %pointer to the asychronous request
* * %NULL if the allocation failed
*/
static struct osp_update_callback *
osp_update_callback_init(struct osp_object *obj, void *data,
osp_update_interpreter_t interpreter)
{
struct osp_update_callback *ouc;
OBD_ALLOC_PTR(ouc);
if (ouc == NULL)
return NULL;
lu_object_get(osp2lu_obj(obj));
INIT_LIST_HEAD(&ouc->ouc_list);
ouc->ouc_obj = obj;
ouc->ouc_data = data;
ouc->ouc_interpreter = interpreter;
return ouc;
}
/**
* osp_update_callback_fini() - Destroy the osp_update_callback.
* @env: pointer to the thread context
* @ouc: pointer to osp_update_callback
*/
static void osp_update_callback_fini(const struct lu_env *env,
struct osp_update_callback *ouc)
{
LASSERT(list_empty(&ouc->ouc_list));
lu_object_put(env, osp2lu_obj(ouc->ouc_obj));
OBD_FREE_PTR(ouc);
}
/**
* osp_update_interpret() - Interpret the packaged OUT RPC results.
* @env: pointer to the thread context
* @req: pointer to the RPC
* @args: pointer to data used by the interpreter
* @rc: the RPC return value
*
* For every packaged sub-request, call its registered interpreter function.
* Then destroy the sub-request.
*
* Return:
* * %0 for success
* * %negative error number on failure
*/
static int osp_update_interpret(const struct lu_env *env,
struct ptlrpc_request *req, void *args, int rc)
{
struct object_update_reply *reply = NULL;
struct osp_update_args *oaua = args;
struct osp_update_request *our = oaua->oaua_update;
struct osp_thandle *oth;
struct osp_update_callback *ouc;
struct osp_update_callback *next;
int count = 0;
int index = 0;
int rc1 = 0;
ENTRY;
if (our == NULL)
RETURN(0);
/* Sigh env might be NULL in some cases, see
* this calling path.
* osp_send_update_thread()
* ptlrpc_set_wait() ----> null env.
* ptlrpc_check_set()
* osp_update_interpret()
* Let's use env in oaua for this case.
*/
if (env == NULL)
env = oaua->oaua_update_env;
if (req->rq_intr && req->rq_nr_resend != 0) {
struct osp_update_request_sub *ours;
DEBUG_REQ(D_HA, req, "dumping out request\n");
list_for_each_entry(ours, &our->our_req_list, ours_list) {
object_update_request_dump(ours->ours_req, D_HA);
}
}
oaua->oaua_update = NULL;
oth = our->our_th;
if (oaua->oaua_flow_control) {
struct osp_device *osp;
LASSERT(oth != NULL);
osp = dt2osp_dev(oth->ot_super.th_dev);
obd_put_request_slot(&osp->opd_obd->u.cli);
}
/* Unpack the results from the reply message. */
if (req->rq_repmsg != NULL && req->rq_replied) {
reply = req_capsule_server_sized_get(&req->rq_pill,
&RMF_OUT_UPDATE_REPLY,
OUT_UPDATE_REPLY_SIZE);
if (reply == NULL || reply->ourp_magic != UPDATE_REPLY_MAGIC) {
if (rc == 0)
rc = -EPROTO;
} else {
count = reply->ourp_count;
}
}
list_for_each_entry_safe(ouc, next, &our->our_cb_items, ouc_list) {
list_del_init(&ouc->ouc_list);
/* The peer may only have handled some requests (indicated
* by the 'count') in the packaged OUT RPC, we can only get
* results for the handled part. */
if (index < count && reply->ourp_lens[index] > 0 && rc >= 0) {
struct object_update_result *result;
result = object_update_result_get(reply, index, NULL);
if (result == NULL)
rc1 = rc = -EPROTO;
else
rc1 = rc = result->our_rc;
} else if (rc1 >= 0) {
/* The peer did not handle these request, let's return
* -EINVAL to update interpret for now */
if (rc >= 0)
rc1 = -EINVAL;
else
rc1 = rc;
}
if (ouc->ouc_interpreter != NULL)
ouc->ouc_interpreter(env, reply, req, ouc->ouc_obj,
ouc->ouc_data, index, rc1);
osp_update_callback_fini(env, ouc);
index++;
}
if (oaua->oaua_count != NULL && atomic_dec_and_test(oaua->oaua_count))
wake_up(oaua->oaua_waitq);
if (oth != NULL) {
/* oth and osp_update_requests will be destoryed in
* osp_thandle_put */
osp_trans_stop_cb(env, oth, rc);
osp_thandle_put(env, oth);
} else {
osp_update_request_destroy(env, our);
}
RETURN(rc);
}
/**
* osp_unplug_async_request() - Pack all the requests in the shared asynchronous
* idempotent request queue into a single OUT RPC that will be given to the
* background ptlrpcd daemon.
* @env: pointer to the thread context
* @osp: pointer to the OSP device
* @our: pointer to the shared queue
*
* Return:
* * %0 for success
* * %negative error number on failure
*/
int osp_unplug_async_request(const struct lu_env *env,
struct osp_device *osp,
struct osp_update_request *our)
{
struct osp_update_args *args;
struct ptlrpc_request *req = NULL;
int rc;
rc = osp_prep_update_req(env, osp->opd_obd->u.cli.cl_import,
our, &req);
if (rc != 0) {
struct osp_update_callback *ouc;
struct osp_update_callback *next;
list_for_each_entry_safe(ouc, next,
&our->our_cb_items, ouc_list) {
list_del_init(&ouc->ouc_list);
if (ouc->ouc_interpreter != NULL)
ouc->ouc_interpreter(env, NULL, NULL,
ouc->ouc_obj,
ouc->ouc_data, 0, rc);
osp_update_callback_fini(env, ouc);
}
osp_update_request_destroy(env, our);
} else {
args = ptlrpc_req_async_args(args, req);
args->oaua_update = our;
args->oaua_count = NULL;
args->oaua_waitq = NULL;
/* Note: this is asynchronous call for the request, so the
* interrupte cb and current function will be different
* thread, so we need use different env */
args->oaua_update_env = NULL;
args->oaua_flow_control = false;
req->rq_interpret_reply = osp_update_interpret;
ptlrpcd_add_req(req);
}
return rc;
}
/**
* osp_find_or_create_async_update_request() - Find or create (if NOT exist or
* purged) the shared asynchronous idempotent request queue - osp_device::
* opd_async_requests.
* @osp: pointer to the OSP device
*
* If the osp_device::opd_async_requests is not NULL, then return it directly;
* otherwise create new osp_update_request and attach it to opd_async_requests.
*
* Return:
* * %pointer to the shared queue
* * %negative error number on failure
*/
static struct osp_update_request *
osp_find_or_create_async_update_request(struct osp_device *osp)
{
struct osp_update_request *our = osp->opd_async_requests;
if (our != NULL)
return our;
our = osp_update_request_create(&osp->opd_dt_dev);
if (IS_ERR(our))
return our;
osp->opd_async_requests = our;
return our;
}
/**
* osp_insert_update_callback() - Insert an osp_update_callback into the
* osp_update_request.
* @env: pointer to the thread context
* @our: pointer to the shared queue
* @obj: pointer to the operation target object
* @data: pointer to the data used by the interpreter
* @interpreter: pointer to the interpreter function
*
* Insert an osp_update_callback to the osp_update_request. Usually each update
* in the osp_update_request will have one correspondent callback, and these
* callbacks will be called in rq_interpret_reply.
*
* Return:
* * %0 for success
* * %negative error number on failure
*/
int osp_insert_update_callback(const struct lu_env *env,
struct osp_update_request *our,
struct osp_object *obj, void *data,
osp_update_interpreter_t interpreter)
{
struct osp_update_callback *ouc;
ouc = osp_update_callback_init(obj, data, interpreter);
if (ouc == NULL)
RETURN(-ENOMEM);
list_add_tail(&ouc->ouc_list, &our->our_cb_items);
return 0;
}
/**
* osp_insert_async_request() - Insert an asynchronous idempotent request to the
* shared request queue that is attached to the osp_device.
* @env: pointer to the thread context
* @op: operation type, see 'enum update_type'
* @obj: pointer to the operation target
* @count: array size of the subsequent @lens and @bufs
* @lens: buffer length array for the subsequent @bufs
* @bufs: the buffers to compose the request
* @data: pointer to the data used by the interpreter
* @repsize: how many bytes the caller allocated for @data
* @interpreter: pointer to the interpreter function
*
* This function generates a new osp_async_request with the given parameters,
* then tries to insert the request into the osp_device-based shared request
* queue. If the queue is full, then triggers the packaged OUT RPC to purge
* the shared queue firstly, and then re-tries.
*
* NOTE: must hold the osp::opd_async_requests_mutex to serialize concurrent
* osp_insert_async_request call from others.
*
* Return:
* * %0 for success
* * %negative error number on failure
*/
int osp_insert_async_request(const struct lu_env *env, enum update_type op,
struct osp_object *obj, int count,
__u16 *lens, const void **bufs,
void *data, __u32 repsize,
osp_update_interpreter_t interpreter)
{
struct osp_device *osp;
struct osp_update_request *our;
struct object_update *object_update;
size_t max_update_size;
struct object_update_request *ureq;
struct osp_update_request_sub *ours;
int rc = 0;
ENTRY;
osp = lu2osp_dev(osp2lu_obj(obj)->lo_dev);
our = osp_find_or_create_async_update_request(osp);
if (IS_ERR(our))
RETURN(PTR_ERR(our));
again:
ours = osp_current_object_update_request(our);
ureq = ours->ours_req;
max_update_size = ours->ours_req_size -
object_update_request_size(ureq);
object_update = update_buffer_get_update(ureq, ureq->ourq_count);
rc = out_update_pack(env, object_update, &max_update_size, op,
lu_object_fid(osp2lu_obj(obj)), count, lens, bufs,
repsize);
/* The queue is full. */
if (rc == -E2BIG) {
osp->opd_async_requests = NULL;
mutex_unlock(&osp->opd_async_requests_mutex);
rc = osp_unplug_async_request(env, osp, our);
mutex_lock(&osp->opd_async_requests_mutex);
if (rc != 0)
RETURN(rc);
our = osp_find_or_create_async_update_request(osp);
if (IS_ERR(our))
RETURN(PTR_ERR(our));
goto again;
} else {
if (rc < 0)
RETURN(rc);
ureq->ourq_count++;
our->our_update_nr++;
}
rc = osp_insert_update_callback(env, our, obj, data, interpreter);
RETURN(rc);
}
int osp_trans_update_request_create(struct thandle *th)
{
struct osp_thandle *oth = thandle_to_osp_thandle(th);
struct osp_update_request *our;
if (oth->ot_our != NULL)
return 0;
our = osp_update_request_create(th->th_dev);
if (IS_ERR(our)) {
th->th_result = PTR_ERR(our);
return PTR_ERR(our);
}
oth->ot_our = our;
our->our_th = oth;
return 0;
}
void osp_thandle_destroy(const struct lu_env *env,
struct osp_thandle *oth)
{
LASSERT(oth->ot_magic == OSP_THANDLE_MAGIC);
LASSERT(list_empty(&oth->ot_commit_dcb_list));
LASSERT(list_empty(&oth->ot_stop_dcb_list));
if (oth->ot_our != NULL)
osp_update_request_destroy(env, oth->ot_our);
OBD_FREE_PTR(oth);
}
/**
* osp_trans_create() - The OSP layer dt_device_operations::dt_trans_create()
* interface to create a transaction.
* @env: pointer to the thread context
* @d: pointer to the OSP dt_device
*
* There are two kinds of transactions that will involve OSP:
*
* 1) If the transaction only contains the updates on remote server
* (MDT or OST), such as re-generating the lost OST-object for
* LFSCK, then it is a remote transaction. For remote transaction,
* the upper layer caller (such as the LFSCK engine) will call the
* dt_trans_create() (with the OSP dt_device as the parameter),
* then the call will be directed to the osp_trans_create() that
* creates the transaction handler and returns it to the caller.
*
* 2) If the transcation contains both local and remote updates,
* such as cross MDTs create under DNE mode, then the upper layer
* caller will not trigger osp_trans_create(). Instead, it will
* call dt_trans_create() on other dt_device, such as LOD that
* will generate the transaction handler. Such handler will be
* used by the whole transaction in subsequent sub-operations.
*
* Return:
* * %pointer to the transaction handler
* * %negative error number on failure
*/
struct thandle *osp_trans_create(const struct lu_env *env, struct dt_device *d)
{
struct osp_thandle *oth;
struct thandle *th = NULL;
ENTRY;
OBD_ALLOC_PTR(oth);
if (unlikely(oth == NULL))
RETURN(ERR_PTR(-ENOMEM));
oth->ot_magic = OSP_THANDLE_MAGIC;
th = &oth->ot_super;
th->th_dev = d;
atomic_set(&oth->ot_refcount, 1);
INIT_LIST_HEAD(&oth->ot_commit_dcb_list);
INIT_LIST_HEAD(&oth->ot_stop_dcb_list);
RETURN(th);
}
/**
* osp_trans_cb_add() - Add commit callback to transaction.
* @th: the thandle
* @dcb: commit callback structure
*
* Add commit callback to the osp thandle, which will be called
* when the thandle is committed remotely.
*
* Return only 0 for now.
*/
int osp_trans_cb_add(struct thandle *th, struct dt_txn_commit_cb *dcb)
{
struct osp_thandle *oth = thandle_to_osp_thandle(th);
LASSERT(dcb->dcb_magic == TRANS_COMMIT_CB_MAGIC);
LASSERT(&dcb->dcb_func != NULL);
if (dcb->dcb_flags & DCB_TRANS_STOP)
list_add(&dcb->dcb_linkage, &oth->ot_stop_dcb_list);
else
list_add(&dcb->dcb_linkage, &oth->ot_commit_dcb_list);
return 0;
}
static void osp_trans_commit_cb(struct osp_thandle *oth, int result)
{
struct dt_txn_commit_cb *dcb;
struct dt_txn_commit_cb *tmp;
LASSERT(atomic_read(&oth->ot_refcount) > 0);
/* call per-transaction callbacks if any */
list_for_each_entry_safe(dcb, tmp, &oth->ot_commit_dcb_list,
dcb_linkage) {
LASSERTF(dcb->dcb_magic == TRANS_COMMIT_CB_MAGIC,
"commit callback entry: magic=%x name='%s'\n",
dcb->dcb_magic, dcb->dcb_name);
list_del_init(&dcb->dcb_linkage);
dcb->dcb_func(NULL, &oth->ot_super, dcb, result);
}
}
static void osp_request_commit_cb(struct ptlrpc_request *req)
{
struct thandle *th = req->rq_cb_data;
struct osp_thandle *oth;
__u64 last_committed_transno = 0;
int result = req->rq_status;
ENTRY;
if (th == NULL)
RETURN_EXIT;
oth = thandle_to_osp_thandle(th);
if (req->rq_repmsg != NULL &&
lustre_msg_get_last_committed(req->rq_repmsg))
last_committed_transno =
lustre_msg_get_last_committed(req->rq_repmsg);
if (last_committed_transno <
req->rq_import->imp_peer_committed_transno)
last_committed_transno =
req->rq_import->imp_peer_committed_transno;
CDEBUG(D_HA, "trans no %llu committed transno %llu\n",
req->rq_transno, last_committed_transno);
/* If the transaction is not really committed, mark result = 1 */
if (req->rq_transno != 0 &&
(req->rq_transno > last_committed_transno) && result == 0)
result = 1;
osp_trans_commit_cb(oth, result);
req->rq_committed = 1;
osp_thandle_put(NULL, oth);
EXIT;
}
/**
* osp_trans_callback() - callback of osp transaction
* @env: execution environment
* @oth: osp thandle
* @rc: result of the osp thandle
*
* Call all of callbacks for this osp thandle. This will only be
* called in error handler path. In the normal processing path,
* these callback will be called in osp_request_commit_cb() and
* osp_update_interpret().
*/
void osp_trans_callback(const struct lu_env *env,
struct osp_thandle *oth, int rc)
{
struct osp_update_callback *ouc;
struct osp_update_callback *next;
if (oth->ot_our != NULL) {
list_for_each_entry_safe(ouc, next,
&oth->ot_our->our_cb_items, ouc_list) {
list_del_init(&ouc->ouc_list);
if (ouc->ouc_interpreter != NULL)
ouc->ouc_interpreter(env, NULL, NULL,
ouc->ouc_obj,
ouc->ouc_data, 0, rc);
osp_update_callback_fini(env, ouc);
}
}
osp_trans_stop_cb(env, oth, rc);
osp_trans_commit_cb(oth, rc);
}
/**
* osp_send_update_req() - Send the request for remote updates.
* @env: pointer to the thread context
* @osp: pointer to the OSP device
* @our: pointer to the osp_update_request
*
* Send updates to the remote MDT. Prepare the request by osp_update_req
* and send them to remote MDT, for sync request, it will wait
* until the reply return, otherwise hand it to ptlrpcd.
*
* Please refer to osp_trans_create() for transaction type.
*
* Return:
* * %0 for success
* * %negative error number on failure
*/
static int osp_send_update_req(const struct lu_env *env,
struct osp_device *osp,
struct osp_update_request *our)
{
struct osp_update_args *args;
struct ptlrpc_request *req;
struct osp_thandle *oth = our->our_th;
struct osp_updates *ou = osp->opd_update;
int rc = 0;
ENTRY;
LASSERT(oth != NULL);
LASSERT(osp->opd_obd);
if (ou && ou->ou_generation != our->our_generation) {
rc = -ESTALE;
osp_trans_callback(env, oth, rc);
CDEBUG(D_HA, "%s: stale tx: gen %llu != %llu: rc = %d\n",
osp->opd_obd->obd_name, ou->ou_generation,
our->our_generation, rc);
RETURN(rc);
}
rc = osp_prep_update_req(env, osp->opd_obd->u.cli.cl_import,
our, &req);
if (rc != 0) {
osp_trans_callback(env, oth, rc);
RETURN(rc);
}
args = ptlrpc_req_async_args(args, req);
args->oaua_update = our;
/* set env to NULL, in case the interrupt cb and current function
* are in different thread */
args->oaua_update_env = NULL;
osp_thandle_get(oth); /* hold for update interpret */
req->rq_interpret_reply = osp_update_interpret;
if (!oth->ot_super.th_wait_submit && !oth->ot_super.th_sync) {
if (!osp->opd_imp_active || !osp->opd_imp_connected) {
osp_trans_callback(env, oth, rc);
osp_thandle_put(env, oth);
GOTO(out, rc = -ENOTCONN);
}
rc = obd_get_request_slot(&osp->opd_obd->u.cli);
if (rc != 0) {
osp_trans_callback(env, oth, rc);
osp_thandle_put(env, oth);
GOTO(out, rc = -ENOTCONN);
}
args->oaua_flow_control = true;
if (!osp->opd_connect_mdt) {
down_read(&osp->opd_async_updates_rwsem);
args->oaua_count = &osp->opd_async_updates_count;
args->oaua_waitq = &osp->opd_sync_barrier_waitq;
up_read(&osp->opd_async_updates_rwsem);
atomic_inc(args->oaua_count);
}
ptlrpcd_add_req(req);
req = NULL;
} else {
osp_thandle_get(oth); /* hold for commit callback */
req->rq_commit_cb = osp_request_commit_cb;
req->rq_cb_data = &oth->ot_super;
args->oaua_flow_control = false;
/* If the transaction is created during MDT recoverying
* process, it means this is an recovery update, we need
* to let OSP send it anyway without checking recoverying
* status, in case the other target is being recoveried
* at the same time, and if we wait here for the import
* to be recoveryed, it might cause deadlock */
osp_set_req_replay(osp, req);
/* Because this req will be synchronus, i.e. it will be called
* in the same thread, so it will be safe to use current
* env */
args->oaua_update_env = env;
if (osp->opd_connect_mdt)
ptlrpc_get_mod_rpc_slot(req);
rc = ptlrpc_queue_wait(req);
if (osp->opd_connect_mdt)
ptlrpc_put_mod_rpc_slot(req);
/* We use rq_queued_time_ns to distinguish between local
* and remote -ENOMEM. */
if ((rc == -ENOMEM && req->rq_queued_time_ns == 0) ||
(req->rq_transno == 0 && !req->rq_committed)) {
if (args->oaua_update != NULL) {
/* If osp_update_interpret is not being called,
* release the osp_thandle */
args->oaua_update = NULL;
osp_thandle_put(env, oth);
}
req->rq_cb_data = NULL;
rc = rc == 0 ? req->rq_status : rc;
osp_trans_callback(env, oth, rc);
osp_thandle_put(env, oth);
GOTO(out, rc);
}
}
out:
if (req != NULL)
ptlrpc_req_put(req);
RETURN(rc);
}
/**
* osp_get_storage_thandle() - Get local thandle for osp_thandle
* @env: pointer to the thread context
* @th: pointer to the transaction handler
* @osp: pointer to the OSP device
*
* Get the local OSD thandle from the OSP thandle. Currently, there
* are a few OSP API (osp_create() and osp_sync_add()) needs
* to update the object on local OSD device.
*
* If the osp_thandle comes from normal stack (MDD->LOD->OSP), then
* we will get local thandle by thandle_get_sub_by_dt.
*
* If the osp_thandle is remote thandle (th_top == NULL, only used
* by LFSCK), then it will create a local thandle, and stop it in
* osp_trans_stop(). And this only happens on OSP for OST.
*
* These are temporary solution, once OSP accessing OSD object is
* being fixed properly, this function should be removed. XXX
*
* Return:
* * %pointer to the local thandle
* * %ERR_PTR(errno) if it fails.
*/
struct thandle *osp_get_storage_thandle(const struct lu_env *env,
struct thandle *th,
struct osp_device *osp)
{
struct osp_thandle *oth;
struct thandle *local_th;
if (th->th_top != NULL)
return thandle_get_sub_by_dt(env, th->th_top,
osp->opd_storage);
LASSERT(!osp->opd_connect_mdt);
oth = thandle_to_osp_thandle(th);
if (oth->ot_storage_th != NULL)
return oth->ot_storage_th;
local_th = dt_trans_create(env, osp->opd_storage);
if (IS_ERR(local_th))
return local_th;
oth->ot_storage_th = local_th;
return local_th;
}
/**
* osp_check_and_set_rpc_version() - Set version for the transaction
* @oth: osp thandle to be set version.
* @obj: arshad
*
* Set the version for the transaction and add the request to
* the sending list, then after transaction stop, the request
* will be sent in the order of version by the sending thread.
*
* Return %0 if set version succeeds or %negative errno if set version fails.
*/
int osp_check_and_set_rpc_version(struct osp_thandle *oth,
struct osp_object *obj)
{
struct osp_device *osp = dt2osp_dev(oth->ot_super.th_dev);
struct osp_updates *ou = osp->opd_update;
if (ou == NULL)
return -EIO;
if (oth->ot_our->our_version != 0)
return 0;
spin_lock(&ou->ou_lock);
spin_lock(&oth->ot_our->our_list_lock);
if (obj->opo_stale) {
spin_unlock(&oth->ot_our->our_list_lock);
spin_unlock(&ou->ou_lock);
return -ESTALE;
}
/* Assign the version and add it to the sending list */
osp_thandle_get(oth);
oth->ot_our->our_version = ou->ou_version++;
oth->ot_our->our_generation = ou->ou_generation;
list_add_tail(&oth->ot_our->our_list,
&osp->opd_update->ou_list);
oth->ot_our->our_req_ready = 0;
spin_unlock(&oth->ot_our->our_list_lock);
spin_unlock(&ou->ou_lock);
LASSERT(oth->ot_super.th_wait_submit == 1);
CDEBUG(D_INFO, "%s: version %llu gen %llu oth:version %p:%llu\n",
osp->opd_obd->obd_name, ou->ou_version, ou->ou_generation, oth,
oth->ot_our->our_version);
return 0;
}
/**
* osp_get_next_request() - Get next OSP update request in the sending list
* @ou: osp update structure.
* @ourp: the pointer holding the next update request.
*
* Get next OSP update request in the sending list by version number, next
* request will be
* 1. transaction which does not have a version number.
* 2. transaction whose version == opd_rpc_version.
*
* Return:
* * %true if getting the next transaction.
* * %false if not getting the next transaction.
*/
static bool
osp_get_next_request(struct osp_updates *ou, struct osp_update_request **ourp)
{
struct osp_update_request *our;
struct osp_update_request *tmp;
bool got_req = false;
spin_lock(&ou->ou_lock);
list_for_each_entry_safe(our, tmp, &ou->ou_list, our_list) {
LASSERT(our->our_th != NULL);
CDEBUG(D_HA, "ou %p version %llu rpc_version %llu\n",
ou, our->our_version, ou->ou_rpc_version);
spin_lock(&our->our_list_lock);
/* Find next osp_update_request in the list */
if (our->our_version == ou->ou_rpc_version &&
our->our_req_ready) {
list_del_init(&our->our_list);
spin_unlock(&our->our_list_lock);
*ourp = our;
got_req = true;
break;
}
spin_unlock(&our->our_list_lock);
}
spin_unlock(&ou->ou_lock);
return got_req;
}
/**
* osp_invalidate_request() - Invalidate update request
* @osp: OSP device whose update requests will be invalidated.
*
* Invalidate update request in the OSP sending list, so all of
* requests in the sending list will return error, which happens
* when it finds one update (with writing llog) requests fails or
* the OSP is evicted by remote target. see osp_send_update_thread().
*/
void osp_invalidate_request(struct osp_device *osp)
{
struct lu_env env;
struct osp_updates *ou = osp->opd_update;
struct osp_update_request *our;
struct osp_update_request *tmp;
LIST_HEAD(list);
int rc;
ENTRY;
if (ou == NULL)
return;
rc = lu_env_init(&env, osp->opd_dt_dev.dd_lu_dev.ld_type->ldt_ctx_tags);
if (rc < 0) {
CERROR("%s: init env error: rc = %d\n", osp->opd_obd->obd_name,
rc);
spin_lock(&ou->ou_lock);
ou->ou_generation++;
spin_unlock(&ou->ou_lock);
return;
}
spin_lock(&ou->ou_lock);
/* invalidate all of request in the sending list */
list_for_each_entry_safe(our, tmp, &ou->ou_list, our_list) {
spin_lock(&our->our_list_lock);
if (our->our_req_ready) {
list_move(&our->our_list, &list);
} else {
/* this thandle won't be forwarded to
* the dedicated thread, so drop the
* reference here */
osp_thandle_put(&env, our->our_th);
list_del_init(&our->our_list);
}
if (our->our_th->ot_super.th_result == 0)
our->our_th->ot_super.th_result = -EIO;
if (our->our_version >= ou->ou_rpc_version)
ou->ou_rpc_version = our->our_version + 1;
spin_unlock(&our->our_list_lock);
CDEBUG(D_HA, "%s invalidate our %p\n", osp->opd_obd->obd_name,
our);
}
/* Increase the generation, then the update request with old generation
* will fail with -EIO. */
ou->ou_generation++;
spin_unlock(&ou->ou_lock);
/* invalidate all of request in the sending list */
list_for_each_entry_safe(our, tmp, &list, our_list) {
spin_lock(&our->our_list_lock);
list_del_init(&our->our_list);
spin_unlock(&our->our_list_lock);
osp_trans_callback(&env, our->our_th,
our->our_th->ot_super.th_result);
osp_thandle_put(&env, our->our_th);
}
lu_env_fini(&env);
}
/**
* osp_send_update_thread() - Sending update thread
* @arg: hold the OSP device.
*
* Create thread to send update request to other MDTs, this thread will pull
* out update request from the list in OSP by version number, i.e. it will
* make sure the update request with lower version number will be sent first.
*
* Return:
* * %0 if the thread is created successfully.
* * %negative error if the thread is not created successfully.
*/
int osp_send_update_thread(void *arg)
{
struct lu_env *env;
struct osp_device *osp = arg;
struct osp_updates *ou = osp->opd_update;
struct osp_update_request *our = NULL;
int rc;
ENTRY;
LASSERT(ou != NULL);
env = &ou->ou_env;
while (1) {
our = NULL;
wait_event_idle(ou->ou_waitq,
kthread_should_stop() ||
osp_get_next_request(ou, &our));
if (kthread_should_stop()) {
if (our != NULL) {
osp_trans_callback(env, our->our_th, -EINTR);
osp_thandle_put(env, our->our_th);
}
break;
}
LASSERT(our->our_th != NULL);
if (our->our_th->ot_super.th_result != 0) {
osp_trans_callback(env, our->our_th,
our->our_th->ot_super.th_result);
rc = our->our_th->ot_super.th_result;
} else if (CFS_FAIL_CHECK(OBD_FAIL_INVALIDATE_UPDATE)) {
rc = -EIO;
osp_trans_callback(env, our->our_th, rc);
} else {
rc = osp_send_update_req(env, osp, our);
}
/* Update the rpc version */
spin_lock(&ou->ou_lock);
if (our->our_version == ou->ou_rpc_version)
ou->ou_rpc_version++;
spin_unlock(&ou->ou_lock);
/* If one update request fails, let's fail all of the requests
* in the sending list, because the request in the sending
* list are dependent on either other, continue sending these
* request might cause llog or filesystem corruption */
if (rc < 0)
osp_invalidate_request(osp);
/* Balanced for thandle_get in osp_check_and_set_rpc_version */
osp_thandle_put(env, our->our_th);
}
RETURN(0);
}
/**
* osp_trans_start() - The OSP layer dt_device_operations::dt_trans_start()
* interface to start the transaction.
* @env: pointer to the thread context
* @dt: pointer to the OSP dt_device
* @th: pointer to the transaction handler
*
* If the transaction is a remote transaction, then related remote
* updates will be triggered in the osp_trans_stop().
* Please refer to osp_trans_create() for transaction type.
*
* Return:
* * %0 for success
* * %negative error number on failure
*/
int osp_trans_start(const struct lu_env *env, struct dt_device *dt,
struct thandle *th)
{
struct osp_thandle *oth = thandle_to_osp_thandle(th);
struct osp_device *osp = dt2osp_dev(dt);
struct osp_updates *ou = osp->opd_update;
if (ou) {
LASSERT(oth->ot_our);
oth->ot_our->our_generation = ou->ou_generation;
if (oth->ot_super.th_sync)
oth->ot_our->our_flags |= UPDATE_FL_SYNC;
if (oth->ot_super.th_ignore_quota)
oth->ot_our->our_flags |= UPDATE_FL_IGNORE_QUOTA;
}
/* For remote thandle, if there are local thandle, start it here*/
if (is_only_remote_trans(th) && oth->ot_storage_th != NULL)
return dt_trans_start(env, oth->ot_storage_th->th_dev,
oth->ot_storage_th);
return 0;
}
/**
* osp_trans_stop() - The OSP layer dt_device_operations::dt_trans_stop()
* interface to stop the transaction.
* @env: pointer to the thread context
* @dt: pointer to the OSP dt_device
* @th: pointer to the transaction handler
*
* If the transaction is a remote transaction, related remote
* updates will be triggered at the end of this function.
*
* For synchronous mode update or any failed update, the request
* will be destroyed explicitly when the osp_trans_stop().
*
* Please refer to osp_trans_create() for transaction type.
*
* Return:
* * %0 for success
* * %negative error number on failure
*/
int osp_trans_stop(const struct lu_env *env, struct dt_device *dt,
struct thandle *th)
{
struct osp_thandle *oth = thandle_to_osp_thandle(th);
struct osp_update_request *our = oth->ot_our;
struct osp_device *osp = dt2osp_dev(dt);
int rc = 0;
ENTRY;
/* For remote transaction, if there is local storage thandle,
* stop it first */
if (oth->ot_storage_th != NULL && th->th_top == NULL) {
dt_trans_stop(env, oth->ot_storage_th->th_dev,
oth->ot_storage_th);
oth->ot_storage_th = NULL;
}
if (our == NULL || list_empty(&our->our_req_list)) {
osp_trans_callback(env, oth, th->th_result);
GOTO(out, rc = th->th_result);
}
if (!osp->opd_connect_mdt) {
osp_trans_callback(env, oth, th->th_result);
rc = osp_send_update_req(env, osp, oth->ot_our);
GOTO(out, rc);
}
if (osp->opd_update == NULL) {
osp_trans_callback(env, oth, -EIO);
GOTO(out, rc = -EIO);
}
CDEBUG(D_HA, "%s: add oth %p with version %llu\n",
osp->opd_obd->obd_name, oth, our->our_version);
LASSERT(our->our_req_ready == 0);
spin_lock(&our->our_list_lock);
if (likely(!list_empty(&our->our_list))) {
/* notify sending thread */
our->our_req_ready = 1;
wake_up(&osp->opd_update->ou_waitq);
spin_unlock(&our->our_list_lock);
} else if (th->th_result == 0) {
/* if the request does not needs to be serialized,
* read-only request etc, let's send it right away */
spin_unlock(&our->our_list_lock);
rc = osp_send_update_req(env, osp, our);
} else {
spin_unlock(&our->our_list_lock);
osp_trans_callback(env, oth, th->th_result);
}
out:
osp_thandle_put(env, oth);
RETURN(rc);
}
